refactor(ui): extract extension runtime lifecycle - #882
Merged
benvinegar merged 2 commits intoAug 27, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Greptile SummaryThe PR extracts extension command execution, event-context installation, and runtime capability lifecycle management from
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking test-fixture typing issue to address. The extracted runtime lifecycle preserves committed-state ordering and stale-capability retirement, while the only accepted concern is that new tests bypass structural fixture checking through empty-object type assertions. Files Needing Attention: src/ui/hooks/useExtensionCommandRunner.test.tsx and src/ui/hooks/useExtensionEventContextProvider.test.tsx Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
App[App render] --> Bridge[Extension runtime bridge]
App --> Runner[Command runner]
App --> Provider[Event context provider]
App --> Bindings[Command and navigation bindings]
Bindings -->|layout commit| Bridge
Bridge --> Lease[Registry and review leases]
Bridge --> Projection[Committed and render projections]
Runner --> Context[Extension command context]
Provider --> Events[Lifecycle and custom events]
Lease -->|reload or unmount| Retired[Retired controls become inert]
Prompt To Fix All With AI### Issue 1
src/ui/hooks/useExtensionCommandRunner.test.tsx:20
**Partial mocks bypass typing**
The new hook tests construct partial extension-capability fixtures with `{} as ...` assertions instead of the required `@total-typescript/shoehorn` helpers. This bypasses structural checking and allows capability contracts to change without useful compile-time failures; the same pattern appears in `useExtensionEventContextProvider.test.tsx`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "refactor(ui): isolate extension runtime ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| import { createEmptyExtensionLoadResult, type RegisteredCommand } from "../../extensions/types"; | ||
| import { useExtensionCommandRunner } from "./useExtensionCommandRunner"; | ||
|
|
||
| const commandControls = {} as ExtensionCommandControls; |
Contributor
There was a problem hiding this comment.
The new hook tests construct partial extension-capability fixtures with {} as ... assertions instead of the required @total-typescript/shoehorn helpers. This bypasses structural checking and allows capability contracts to change without useful compile-time failures; the same pattern appears in useExtensionEventContextProvider.test.tsx.
Context Used: testing.mdc Cursor rule (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/ui/hooks/useExtensionCommandRunner.test.tsx
Line: 20
Comment:
**Partial mocks bypass typing**
The new hook tests construct partial extension-capability fixtures with `{} as ...` assertions instead of the required `@total-typescript/shoehorn` helpers. This bypasses structural checking and allows capability contracts to change without useful compile-time failures; the same pattern appears in `useExtensionEventContextProvider.test.tsx`.
**Context Used:** testing.mdc Cursor rule ([source](https://github.com/modem-dev/modem/blob/main/.cursor/rules/testing.mdc))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
benvinegar
force-pushed
the
refactor/extension-pane-controller
branch
from
August 27, 2026 12:13
acd7b42 to
b0b60d1
Compare
benvinegar
force-pushed
the
refactor/extension-runtime-bridge
branch
from
August 27, 2026 12:14
55e431c to
8bde834
Compare
benvinegar
merged commit Aug 27, 2026
559cd22
into
refactor/extension-pane-controller
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppTesting
bun run typecheckbun run deps:checkbun run lintStack
This PR description was generated by Pi using GPT-5.6 Sol